Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot Manager #18329

Closed
4 tasks done
Tracked by #17041
cool-develope opened this issue Nov 1, 2023 · 7 comments
Closed
4 tasks done
Tracked by #17041

Snapshot Manager #18329

cool-develope opened this issue Nov 1, 2023 · 7 comments
Assignees
Labels

Comments

@cool-develope
Copy link
Contributor

cool-develope commented Nov 1, 2023

We need to implement a new snapshot manager (SM) for state syncing in the store v2 package. It should define the state storage snapshot struct and redesign the snapshot flow in terms of service considering the pruning manager.

Tasks

Preview Give feedback
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Nov 1, 2023
@cool-develope cool-develope removed the needs-triage Issue that needs to be triaged label Nov 1, 2023
@cool-develope cool-develope self-assigned this Nov 1, 2023
@tac0turtle
Copy link
Member

Hey could you update the issue description with what this issue entails. Empty issue descriptions make it harder to review prs.

@alexanderbez
Copy link
Contributor

@cool-develope I'd suggest just a simple task list of items that the SM should be able to perform (e.g. export, sync/import, and how it connect to the RootStore). Maybe lifecycle stuff too.

@cool-develope
Copy link
Contributor Author

@tac0turtle @alexanderbez
I listed the small tasks of the SM implementation, let me know if any opinions.

@alexanderbez
Copy link
Contributor

Yes, LGTM!

@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Nov 13, 2023
@tac0turtle tac0turtle moved this from 👀 To Do to 📚 In review in Cosmos-SDK Nov 14, 2023
@cool-develope cool-develope moved this from 📚 In review to 🥳 Done in Cosmos-SDK Dec 8, 2023
@alexanderbez
Copy link
Contributor

@cool-develope what's the status of this?

@cool-develope
Copy link
Contributor Author

done with #18458 , #18526

@alexanderbez
Copy link
Contributor

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

No branches or pull requests

3 participants