Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect changelog entry #18980

Closed
rootulp opened this issue Jan 8, 2024 · 1 comment
Closed

Incorrect changelog entry #18980

rootulp opened this issue Jan 8, 2024 · 1 comment
Labels
needs-triage Issue that needs to be triaged

Comments

@rootulp
Copy link
Contributor

rootulp commented Jan 8, 2024 •
edited
Loading

Context

cosmos-sdk/CHANGELOG.md

Line 626 in 6a2329f

* (cli) [#17188](https://github.com/cosmos/cosmos-sdk/pull/17188) Fix `--output-document` flag in `tx multi-sign`.

Problem

This line of the changelog is misleading. The linked PR hides the --output flag but the --output-document flag still exists. See https://github.com/cosmos/cosmos-sdk/pull/17188/files#diff-753fbc24a104ed25e69fa8b3c5cd5d722073d156de1f4a0d8bb979fdbc712835R225.

Proposal

Since the changelog entry is wrong, proposal to update it to something like: "refactor: hide --output flags that don't work".

On a related note, it looks like something is wrong with the --output-document flag. See celestiaorg/celestia-app#2980
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jan 8, 2024
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Jan 8, 2024
@rootulp
Copy link
Contributor Author

rootulp commented Jan 8, 2024

Sorry my bad. It looks like that PR hides the --output flag AND fixes the --output-document flag.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
@github-project-automation github-project-automation bot moved this from 👀 To Do to 🥳 Done in Cosmos-SDK Jan 8, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Issue that needs to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp