Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Modules need to query consensus for params #19597

Closed
tac0turtle opened this issue Feb 29, 2024 · 0 comments · Fixed by #19600
Closed

[chore]: Modules need to query consensus for params #19597

tac0turtle opened this issue Feb 29, 2024 · 0 comments · Fixed by #19600
Assignees
Labels
C:server/v2 Issues related to server/v2 T:feature-request

Comments

@tac0turtle
Copy link
Member

Summary

In server/v2 we are moving away from a context holding all the information. This leads to modules that get consensus params needing to query consensus params each time they need it.

Problem Definition

No response

Proposed Feature

migrate modules that use consensus params to query it from the consensus module.

modules can use this router to get the needed information #19571

@tac0turtle tac0turtle added T:feature-request C:server/v2 Issues related to server/v2 labels Feb 29, 2024
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Feb 29, 2024
@tac0turtle tac0turtle self-assigned this Feb 29, 2024
@tac0turtle tac0turtle moved this from 👀 To Do to 📚 In review in Cosmos-SDK Feb 29, 2024
@github-project-automation github-project-automation bot moved this from 👀 Waiting / In review to 🥳 Done in Cosmos-SDK Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2 T:feature-request
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

1 participant