-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP Deprecation header to legacy REST endpoints #7636
Comments
Does deprecation imply that an endpoint currently functions as expected? I ask because I don't think this is the case for all endpoints (particularly the I wonder if we need (separately from this issue), a better solution to the above problem. Or at least we should make sure to be explicit in our documentation about what we mean by deprecated here. Update: Added #7639 to track this |
Yes, specifically the functionality remains unchanged and non-breaking. However, this is specific to a given context. Namely, yes, the endpoints will work as expected assuming you work with legacy data (e.g. amino-encoded txs). If you attempt to use this endpoint with data built upon new functionality, you really don't get any guarantees towards backwards compatibility. In such a case, explorers should use these endpoints wisely, where they should strive to use the new endpoints where possible. |
This will make it easier for users transitioning to stargate. The header should link to documentation on upgrading.
See https://tools.ietf.org/id/draft-dalal-deprecation-header-01.html
We may additionally want to consider Sunset (https://tools.ietf.org/html/rfc8594) and or Warning (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Warning) headers.
The text was updated successfully, but these errors were encountered: