Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IBC unreceived packets query #7651

Closed
4 tasks
colin-axner opened this issue Oct 23, 2020 · 2 comments
Closed
4 tasks

Fix IBC unreceived packets query #7651

colin-axner opened this issue Oct 23, 2020 · 2 comments
Labels
C:CLI good first issue T:Bug T: Client UX
Milestone
IBC 1.0 Implement...

Comments

@colin-axner
Copy link
Contributor

Summary

UnreceivedPackets grpc should query for missing receipts not acknowledgements. In addition to this the cli cmds need to accept 2 arguments not 3 for both unreceived packet and unrelayed acks

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@colin-axner colin-axner mentioned this issue Oct 30, 2020
Merged
9 tasks
@AdityaSripal
Copy link
Member

AdityaSripal commented Oct 30, 2020 •
edited
Loading

The CLI correctly accepts 3 arguments to take in portID, channelID, and sequences.

EDIT: nvm, looks like sequences is a flag argument

@AdityaSripal
Copy link
Member

Closed via #7735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:CLI good first issue T:Bug T: Client UX
Projects
None yet
Milestone
IBC 1.0 Implementation Audit
Development

No branches or pull requests
2 participants
@AdityaSripal @colin-axner