-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multisig LegacyAminoPubKey Amino marshaling (bp #8841) #8878
Conversation
* Use v034auth RegisterCrypto * Add custom amino for LegacyAminoPubKey * Fix registercrypto * Revert old PR * revert some genutil stuff * Add comment * Add changelog * Remove binary marshalling * Fix lint * Fix lint again * Fix lint, 3rd time's a charm * ignore wrong linter warning * Fix UnmarshalAmioJSON Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Anil Kumar Kammari <[email protected]> (cherry picked from commit d4d27e1) # Conflicts: # CHANGELOG.md # x/auth/legacy/v040/migrate.go
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=0d0fccfae5f74809821d0d96155ece66 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=c292fb458cf7152658dbdbab95852b27371ac686 |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=5f893123711c4d0e9cd7ff6c6a910bfb |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=1e17860e8929afc0f6c3c6980258ffea2d06ae82 |
This is an automatic backport of pull request #8841 done by Mergify.
closes: #8776
Cherry-pick of d4d27e1 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/