-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add orderBy parameter to TxsByEvents (bp #8815) #8883
Conversation
* add orderBy parameter to grpc query * add orderby parameter * change orderBy param to enum * lint * proto lint * add changelog * Update x/auth/tx/service.go Co-authored-by: Amaury <[email protected]> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]> Co-authored-by: Amaury <[email protected]> (cherry picked from commit 553aac5) # Conflicts: # x/auth/tx/service.go
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=85bf25e0384046fd8b8b93ec097bb08f |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=8857b99823b883c483143ecc450f18e40121c921 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adf5f62 also needs to be backported into the same PR. @aleem1314 could you take care of that?
Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Jonathan Gimeno <[email protected]>
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=e0d8617088534f7abb7afe5f6b62c532 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=e3fc8679c730d70b6068682a0dbd6589223d05f1 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=bb8e07b8d0e47c66bcac2642dc29f4c14e07cd13 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=8dc96c12325dfe158a32b2ec2a7ba322cf73715c |
@aleem1314 there seems to be proto breakage, can we bump the version? |
@sahith-narahari No, this CI check is not working properly on In the meantime, a manual check confirms that this is NOT a proto-breaking change (only proto additions). If someone else wans to double-check, that would be good. |
Thanks, that makes sense. |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=177672fd147c3924dbe6df8dcb253524717c30b0 |
This is an automatic backport of pull request #8815 done by Mergify.
Cherry-pick of 553aac5 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/