Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #8905

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Fix typo #8905

merged 2 commits into from
Mar 17, 2021

Conversation

hallazzang
Copy link
Contributor

Description

It fixes two typo in simapp/params/doc.go


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #8905 (92c1f0e) into master (42919c8) will increase coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8905   +/-   ##
=======================================
  Coverage   59.17%   59.17%           
=======================================
  Files         571      571           
  Lines       31800    31807    +7     
=======================================
+ Hits        18817    18822    +5     
- Misses      10780    10782    +2     
  Partials     2203     2203           
Impacted Files Coverage Δ
types/errors/errors.go 79.31% <0.00%> (-2.84%) ⬇️
types/address.go 66.66% <100.00%> (+0.65%) ⬆️
x/auth/tx/service.go 72.85% <100.00%> (ø)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!! Thank you for the contribution!!

@sahith-narahari sahith-narahari added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 17, 2021
@mergify mergify bot merged commit 0836361 into cosmos:master Mar 17, 2021
@orijbot
Copy link

orijbot commented Mar 17, 2021

@orijbot
Copy link

orijbot commented Mar 17, 2021

@mergify mergify bot mentioned this pull request Mar 17, 2021
alessio pushed a commit that referenced this pull request Mar 17, 2021
Co-authored-by: Marko <[email protected]>
(cherry picked from commit 0836361)

Co-authored-by: Hanjun Kim <[email protected]>
mergify bot pushed a commit that referenced this pull request Mar 17, 2021
Co-authored-by: Marko <[email protected]>
(cherry picked from commit 0836361)
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants