Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/authz audit Updates #9114

Closed
clevinson opened this issue Apr 14, 2021 · 4 comments
Closed

x/authz audit Updates #9114

clevinson opened this issue Apr 14, 2021 · 4 comments
Assignees
Milestone

Comments

@clevinson
Copy link
Contributor

clevinson commented Apr 14, 2021

Any updates that come out of the x/authz API audit.

Scope of work: #9037

@clevinson clevinson added this to the v0.43 milestone Apr 14, 2021
@robert-zaremba robert-zaremba changed the title x/authz API Updates x/authz audit Updates Apr 14, 2021
@robert-zaremba robert-zaremba self-assigned this Apr 14, 2021
@amaury1093
Copy link
Contributor

amaury1093 commented Apr 21, 2021

One thing to add: in #9139 we're removing service msgs, so authz's MethodName() doesn't make sense anymore since there's no more method. Maybe MsgName() or MsgTypeURL()?

Edit: ref #9139 (comment) and #9139 (comment)

@robert-zaremba
Copy link
Collaborator

One thing to add: in #9139 we're removing service msgs, so authz's MethodName() doesn't make sense anymore since there's no more method. Maybe MsgName() or MsgTypeURL()?

So, we don't need that function at all, right?
As for the attribute - we already changed it to msg_type_url

@amaury1093
Copy link
Contributor

If i'm not mistaken, this issue can be closed?

@robert-zaremba
Copy link
Collaborator

yes, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants