Migrate x/params to protocol buffers for state encoding #7114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clevinson
commented
Aug 20, 2020
x/params/types/subspace.go
Outdated
|
|
||
| if pty != ty { | ||
| if registeredProtoMarshaler != value { |
There was a problem hiding this comment.
This actually needs to check for type equality, not value equality.
@alexanderbez @aaronc Is there a way to do that without reflection?
There was a problem hiding this comment.
You mean the concrete types? No, I can't think of any other way apart from reflection.
clevinson
commented
Aug 20, 2020
x/auth/types/params.go
Outdated
| @@ -54,7 +54,7 @@ func ParamKeyTable() paramtypes.KeyTable { | |||
| func (p *Params) ParamSetPairs() paramtypes.ParamSetPairs { | |||
|
|
|||
| return paramtypes.ParamSetPairs{ | |||
| paramtypes.NewParamSetPair(KeyMaxMemoCharacters, p.MaxMemoCharacters, validateMaxMemoCharacters), | |||
| paramtypes.NewParamSetPair(KeyMaxMemoCharacters, &pt.UInt64Value{Value: p.MaxMemoCharacters}, validateMaxMemoCharacters), | |||
There was a problem hiding this comment.
@alexanderbez this is the kind of stuff we would need all over the place for param values if we wanted to keep the proto representation as primitive types.
clevinson
force-pushed
the
clevinson/params-proto-encoding
branch
from
83f8fd5 to
a156dca
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the x/params module to use protobuf for encoding params state in its store.
The main change is updating this struct:
// source: x/params/types/paramset.go ParamSetPair struct { Key []byte - Value interface{} + Value codec.ProtoMarshaler ValidatorFn ValueValidatorFn }And subsequently updating all marshalers, validator functions, and other downstream refactoring...
This PR will also migrate the params for each module.
closes: #6983
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes