Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic state verification functions to ClientState interface #1145

Closed
4 of 7 tasks
damiannolan opened this issue Mar 21, 2022 · 3 comments
Closed
4 of 7 tasks

Add generic state verification functions to ClientState interface #1145

damiannolan opened this issue Mar 21, 2022 · 3 comments

Comments

@damiannolan
Copy link
Member

damiannolan commented Mar 21, 2022

Summary

Add two new generic state verification functions to the ClientState interface.

  • VerifyMembership
  • VerifyNonMembership

ref: cosmos/ibc#687

Proposal

Separate PRs can be made to split up the work:

  • Add new VerifyMembership and VerifyNonMembership to ClientState interface
  • 06-solomachine implementation
  • 07-tendermint implementation
  • 09-localhost implementation

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor

For the solo machine implementation, to avoid being blocked by #1141, a switch case should be used on the provided path. If the path matches a supported type then the sign bytes can be constructed, otherwise an error should be returned. The implementation of #1141 will extend the generic verify functions for the solomachine to accept any path

@damiannolan
Copy link
Member Author

I have a WIP branch for this from a few weeks ago so will self-assign!
PRs will be split up. I'll remove localhost from checklist

@damiannolan damiannolan self-assigned this Apr 19, 2022
@colin-axner colin-axner self-assigned this Apr 25, 2022
@colin-axner
Copy link
Contributor

I can do the 07-tendermint changes

@crodriguezvega crodriguezvega moved this from Todo to Backlog in ibc-go May 1, 2022
@colin-axner colin-axner removed their assignment May 11, 2022
@colin-axner colin-axner moved this from Backlog to Todo in ibc-go May 18, 2022
@seantking seantking self-assigned this Jun 29, 2022
Repository owner moved this from Todo to Done in ibc-go Jul 6, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
## Overview

This PR improves upon cosmos#1144 by simplifying `mock.Server` to use
`httptest` directly, avoiding a duplicate `http.Server`. `Server.Start`
doesn't need a listener anymore, and it returns the URL at which the
`httptest.Server` is running.

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants