You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a test which requires relayers to clear packet queues for all channel types.
Problem Definition
Due to a bug in unreceived packets grpc, hermes was unable to clear packet for ordered channels (interchain accounts).
Proposal
Add an e2e test which would have caught this bug earlier and will protect us against a regression
The test should send out several packets for ordered and unordered channels, then it should start the relayer to have the relayers clear the packet queue. Ideally check that the e2e tests fails when you revert the patch fix above, that way we can be certain we can catch the bug with our tests if the code regressed
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
I'll tackle this one, wanna write some e2e tests. Would it make sense to add a separate regressions/ folder? Alternatively, a regressions_test.go in the relevant folders could be better.
I don't have a strong preference, but this seems like a good test to have outside of catching regressions. I could see it going in the core/04-channel sub directory for tests. What do you think?
Summary
Add a test which requires relayers to clear packet queues for all channel types.
Problem Definition
Due to a bug in unreceived packets grpc, hermes was unable to clear packet for ordered channels (interchain accounts).
Proposal
Add an e2e test which would have caught this bug earlier and will protect us against a regression
The test should send out several packets for ordered and unordered channels, then it should start the relayer to have the relayers clear the packet queue. Ideally check that the e2e tests fails when you revert the patch fix above, that way we can be certain we can catch the bug with our tests if the code regressed
For Admin Use
The text was updated successfully, but these errors were encountered: