Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for clearing packet queues #3626

Open
3 tasks
colin-axner opened this issue May 22, 2023 · 3 comments
Open
3 tasks

Add e2e test for clearing packet queues #3626

colin-axner opened this issue May 22, 2023 · 3 comments
Labels

Comments

@colin-axner
Copy link
Contributor

Summary

Add a test which requires relayers to clear packet queues for all channel types.

Problem Definition

Due to a bug in unreceived packets grpc, hermes was unable to clear packet for ordered channels (interchain accounts).

Proposal

Add an e2e test which would have caught this bug earlier and will protect us against a regression

The test should send out several packets for ordered and unordered channels, then it should start the relayer to have the relayers clear the packet queue. Ideally check that the e2e tests fails when you revert the patch fix above, that way we can be certain we can catch the bug with our tests if the code regressed


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim
Copy link
Contributor

DimitrisJim commented May 23, 2023

I'll tackle this one, wanna write some e2e tests. Would it make sense to add a separate regressions/ folder? Alternatively, a regressions_test.go in the relevant folders could be better.

@DimitrisJim DimitrisJim self-assigned this May 23, 2023
@colin-axner
Copy link
Contributor Author

I don't have a strong preference, but this seems like a good test to have outside of catching regressions. I could see it going in the core/04-channel sub directory for tests. What do you think?

@DimitrisJim
Copy link
Contributor

What do you think?

I think that's what I also started with. Will play around with it and see how well it works out.

@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jun 12, 2023
@crodriguezvega crodriguezvega moved this from Todo to Backlog in ibc-go Oct 6, 2023
@DimitrisJim DimitrisJim removed their assignment Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog 🕐
Development

No branches or pull requests

2 participants