Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC event for channel_open_init has module ibc_connection #601

Closed
3 tasks
ancazamfir opened this issue Dec 6, 2021 · 4 comments · Fixed by #603
Closed
3 tasks

IBC event for channel_open_init has module ibc_connection #601

ancazamfir opened this issue Dec 6, 2021 · 4 comments · Fixed by #603
Milestone

Comments

@ancazamfir
Copy link

Summary of Bug

IBC event for channel_open_init has module ibc_connection instead of ibc_channel

Version

Tested hermes with gaia v6.0.0:

	github.com/cosmos/cosmos-sdk v0.44.3
	github.com/cosmos/ibc-go/v2 v2.0.0

With gaia v5.0.8 the module is ibc_channel.

Steps to Reproduce

Start two gaia chains, create clients and connection, then hermes tx raw chan-open-init ibc-0 ibc-1 connection-0 transfer transfer while listening with hermes listen ibc-0 -e Tx. I can provide more details if required.
A custom hermes trace shows:

            Event {
                type_str: "channel_open_init",
                attributes: [
                    Tag {
                        key: Key(
                            "port_id",
                        ),
                        value: Value(
                            "transfer",
                        ),
                    },
                    Tag {
                        key: Key(
                            "channel_id",
                        ),
                        value: Value(
                            "channel-1",
                        ),
                    },
                    Tag {
                        key: Key(
                            "counterparty_port_id",
                        ),
                        value: Value(
                            "transfer",
                        ),
                    },
                    Tag {
                        key: Key(
                            "counterparty_channel_id",
                        ),
                        value: Value(
                            "",
                        ),
                    },
                    Tag {
                        key: Key(
                            "connection_id",
                        ),
                        value: Value(
                            "connection-0",
                        ),
                    },
                ],
            },
            Event {
                type_str: "message",
                attributes: [
                    Tag {
                        key: Key(
                            "module",
                        ),
                        value: Value(
                            "ibc_connection",
                        ),
                    },
                ],
            },

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking
Copy link
Contributor

Interesting! I see that we are emitting the correct event on our side here

I'll take a look at the logs on-chain rather than the hermes side.

@seantking
Copy link
Contributor

seantking commented Dec 6, 2021

Ah actually we are emitting the module part here. I see we are using connectiontypes

@crodriguezvega
Copy link
Contributor

Thank you for this finding, @ancazamfir!

@colin-axner
Copy link
Contributor

nice catch @ancazamfir! Thank you!

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
…osmos#601)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3.3.0...v3.3.1)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants