Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a NoForwarding helper function to use in tests #6723

Closed
3 tasks
DimitrisJim opened this issue Jun 27, 2024 · 1 comment · Fixed by #6774
Closed
3 tasks

Add a NoForwarding helper function to use in tests #6723

DimitrisJim opened this issue Jun 27, 2024 · 1 comment · Fixed by #6774
Assignees
@hakuno2000
Labels
good first issue Good for newcomers testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jun 27, 2024 •
edited
Loading

See review comment here #6693 (comment)

Basically a function that returns an Forwarding object with all values empty. Could do something similar for ForwardingPacketData.

should be done after feature branch is merged

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces labels Jun 27, 2024
@DimitrisJim DimitrisJim mentioned this issue Jun 27, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Jun 27, 2024
@hakuno2000
Copy link
Contributor

Hello, may I work on this sir?

@hakuno2000 hakuno2000 mentioned this issue Jul 7, 2024
Merged
10 tasks
@github-project-automation github-project-automation bot moved this to Done 🥳 in ibc-go Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hakuno2000 hakuno2000

Labels
good first issue Good for newcomers testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NoForwarding and EmptyForwardingPacketData helper function to use… hakuno2000/ibc-go
3 participants
@crodriguezvega @DimitrisJim @hakuno2000