Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy relayer test race #1004

Closed
agouin opened this issue Sep 23, 2022 · 1 comment · Fixed by #1005
Closed

Legacy relayer test race #1004

agouin opened this issue Sep 23, 2022 · 1 comment · Fixed by #1005

Comments

@agouin
Copy link
Member

agouin commented Sep 23, 2022

https://github.com/cosmos/relayer/actions/runs/3113313198/jobs/5047783982

==================
WARNING: DATA RACE
Read at 0x00c0016f9900 by goroutine 161:
  github.com/cosmos/relayer/v2/relayer.AddMessagesForSequences()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/naive-strategy.go:583 +0x1ee
  github.com/cosmos/relayer/v2/relayer.RelayPackets.func2()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/naive-strategy.go:496 +0x266
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/strangelove/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:74 +0x86

Previous write at 0x00c0016f9900 by goroutine 33:
  [failed to restore the stack]

Goroutine 161 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      /home/strangelove/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:71 +0x12e
  github.com/cosmos/relayer/v2/relayer.RelayPackets()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/naive-strategy.go:495 +0x70e
  github.com/cosmos/relayer/v2/relayer.relayUnrelayedPackets()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/strategies.go:377 +0x910
  github.com/cosmos/relayer/v2/relayer.relayUnrelayedPacketsAndAcks()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/strategies.go:321 +0x169
  github.com/cosmos/relayer/v2/relayer.relayerStartLegacy.func6()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/strategies.go:186 +0x12b

Goroutine 33 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      /home/strangelove/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:71 +0x12e
  github.com/cosmos/relayer/v2/relayer.RelayPackets()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/naive-strategy.go:489 +0x4b2
  github.com/cosmos/relayer/v2/relayer.relayUnrelayedPackets()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/strategies.go:377 +0x910
  github.com/cosmos/relayer/v2/relayer.relayUnrelayedPacketsAndAcks()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/strategies.go:321 +0x169
  github.com/cosmos/relayer/v2/relayer.relayerStartLegacy.func6()
      /home/strangelove/actions-runner/_work/relayer/relayer/relayer/strategies.go:186 +0x12b
==================
@agouin
Copy link
Member Author

agouin commented Sep 23, 2022

Again here https://github.com/cosmos/relayer/actions/runs/3114812966/jobs/5051246353

@agouin agouin mentioned this issue Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix legacy race condition cosmos/relayer
1 participant
@agouin