Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for Relayer #263

Closed
jackzampolin opened this issue May 22, 2020 · 4 comments
Closed

Metrics for Relayer #263

jackzampolin opened this issue May 22, 2020 · 4 comments
Labels
T: Enhancement TYPE: Enhancement T: New Feature TYPE: New features to be added

Comments

@jackzampolin
Copy link
Member

Ideally when running rly start the relayer should expose a Prometheus metrics server which exposes metrics about the operations. This should include:

  • Counter of messages by type
  • Counter of gas used
  • Counter of fees paid by denom/address

This issue is also a place for other ideas for metrics. Please add them as comments!

@jackzampolin jackzampolin added the T: Enhancement TYPE: Enhancement label May 22, 2020
@jackzampolin jackzampolin added this to the 1.0 IBC milestone May 22, 2020
@jackzampolin jackzampolin self-assigned this May 22, 2020
@wangfeiping
Copy link
Contributor

wangfeiping commented May 22, 2020

I think client update time is also important so that relayer operators can customize alarms.
for example:
client_update_status{chain_id="dawnsworld-1b",time="2020-05-21T07:04:29.507285347Z"} 100
Value represents client duration (seconds).

@colin-axner
Copy link
Contributor

reference on how SDK recently added metrics: cosmos/cosmos-sdk#6449

@colin-axner colin-axner removed this from the Relayer Production Readiness milestone Jan 14, 2021
@jtieri jtieri added T: New Feature TYPE: New features to be added and removed ICF labels Jan 12, 2022
@boojamya boojamya assigned DavidNix and unassigned jackzampolin May 24, 2022
@DavidNix
Copy link
Contributor

DavidNix commented May 24, 2022

Are there any other metrics besides these?

  • Counter of messages by type
  • Counter of gas used
  • Counter of fees paid by denom/address

As to the last one Counter of fees paid by denom/address, we may not want to capture address.

My assumption is we will use prometheus-style metrics. Denom and address sounds like it's an unbounded sets of labels.

Per prometheus best practices: https://prometheus.io/docs/practices/naming/#labels

CAUTION: Remember that every unique combination of key-value label pairs represents a new time series, which can dramatically increase the amount of data stored. Do not use labels to store dimensions with high cardinality (many different label values), such as user IDs, email addresses, or other unbounded sets of values.

We may be able to get buy with denom but I recommend not adding addresses as a label.

@agouin
Copy link
Member

agouin commented Aug 30, 2022

Duplicate of #877

@agouin agouin marked this as a duplicate of #877 Aug 30, 2022
@agouin agouin closed this as completed Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Enhancement TYPE: Enhancement T: New Feature TYPE: New features to be added
Projects
None yet
Development

No branches or pull requests

6 participants