tm v0.37.0-rc2, sdk 0.47.0-rc1, and ibc-go v7 #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agouin
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
|
This is ready for review, but currently using https://github.com/strangelove-ventures/ibc-go/tree/andrew/47-rc1 as a replace ibc-go dependency. This should not be merged until we are pointed to an ibc-go commit on the upstream repo. EDIT: updated to ibc-go v7 from main on 01/29/2023. e2e test case for the decoding version boundary here strangelove-ventures/interchaintest#359 |
1 task
agouin
changed the title
jtieri
reviewed
Jan 31, 2023
…nges for sdk 0.47, tm 0.37, ibc-go v6
agouin
force-pushed
the
andrew/tendermint_v0.37
branch
from
bd6307a to
7a37b60
Compare
Those weren't needed actually until pulling in main with the stride changes that introduced
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect tendermint version from nodes for conditional on decoding. When tendermint version is lower than
v0.37-alpha, events are base64 encoded and need to be decoded first. Since calls to nodeStatusare already done to get the latest height, and this response includes the tendermint version, we can keep the flag up to date at runtime. This allows a seamless transition for the relayer when a chain upgrades across the tm v0.37 boundary, the relayer will detect the new version and not need a restart.ibcexported.Headeris nowibcexported.ClientMessageResolves #737