Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone: #Add-devise #10

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Milestone: #Add-devise #10

merged 14 commits into from
Oct 4, 2023

Conversation

cosywasswa
Copy link
Owner

👇 In this pull request, we implemented the following

  • Removed current_user method in ApplicationController
  • Installed devise
  • Implemented the following
  1. Can register a new user
  2. User logs in with a combination of email and password
  3. A hashed password is stored in the database
  4. Asks for confirmation of email
  5. Can reset password
  • Modified view to match wireframe
  • Updated README file
  • Fixed Linter errors

Copy link

@codepantha codepantha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢 ✔️

Hi team 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights 🎯

✔️ Descriptive PR
✔️ Added user authentication with Devise 📌
✔️ No linter errors 🟢

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@cosywasswa cosywasswa merged commit 765bb4e into develop Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants