Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return type J:ORG-226 #732

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix: return type J:ORG-226 #732

merged 1 commit into from
Sep 8, 2023

Conversation

schaoukicoveo
Copy link
Contributor

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@schaoukicoveo schaoukicoveo requested a review from a team September 7, 2023 17:45
@schaoukicoveo schaoukicoveo requested a review from a team as a code owner September 7, 2023 17:45
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@schaoukicoveo schaoukicoveo merged commit 322956c into master Sep 8, 2023
@schaoukicoveo schaoukicoveo deleted the fix/ORG-226 branch September 8, 2023 12:38
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🎉 This PR is included in version 46.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

paulgerold pushed a commit that referenced this pull request Sep 18, 2023
@schaoukicoveo @paulgerold
fix: return type J:ORG-226 (#732)
0fe93f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larosek larosek larosek approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@gdostie gdostie Awaiting requested review from gdostie

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@mrrajamanickam-coveo mrrajamanickam-coveo Awaiting requested review from mrrajamanickam-coveo mrrajamanickam-coveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schaoukicoveo @GermainBergeron @larosek