Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): modify endpoint return type #825

Merged
merged 2 commits into from
May 29, 2024

Conversation

agong-coveo
Copy link
Contributor

@agong-coveo agong-coveo commented May 29, 2024

  • Made a mistake with the endpoint's return type when merging the original PR;
  • To avoid forgetting anything, I've tested this endpoint with the feature that I'm currently developing.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@agong-coveo agong-coveo marked this pull request as ready for review May 29, 2024 13:01
@agong-coveo agong-coveo requested a review from a team May 29, 2024 13:01
@agong-coveo agong-coveo requested a review from a team as a code owner May 29, 2024 13:01
Copy link
Member

@toofff toofff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agong-coveo agong-coveo added this pull request to the merge queue May 29, 2024
Merged via the queue into master with commit 4906375 May 29, 2024
5 checks passed
@agong-coveo agong-coveo deleted the feat/TSP-352-project-multi-selector-edit branch May 29, 2024 14:03
Copy link

🎉 This PR is included in version 54.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants