Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sources): add call to feedback endpoint #833

Merged
merged 2 commits into from
Jun 21, 2024
Merged

feat(sources): add call to feedback endpoint #833

merged 2 commits into from
Jun 21, 2024

Conversation

ClaudineL
Copy link
Contributor

@ClaudineL ClaudineL commented Jun 19, 2024 •
edited
Loading

CTCORE-10099

I implemented all this but realized later that the endpoint not visible in the public Swagger (but the call is publicly available), does my PR qualify then? 🤔

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@ClaudineL ClaudineL force-pushed the feat/CTCORE-10099-Use-the-new-feedback-call-to-send-the-feedback-to-Slack--edit-summary--SMI]-Use-the-new-feedback-call-to-send-the-feedback-to-Slack branch from c7adfcd to 798d34e Compare June 19, 2024 18:30
@ClaudineL ClaudineL marked this pull request as ready for review June 19, 2024 18:33
@ClaudineL ClaudineL requested a review from a team June 19, 2024 18:33
@ClaudineL ClaudineL requested a review from a team as a code owner June 19, 2024 18:33
@ClaudineL ClaudineL added this pull request to the merge queue Jun 21, 2024
Merged via the queue into master with commit 5dc8e81 Jun 21, 2024
5 checks passed
@ClaudineL ClaudineL deleted the feat/CTCORE-10099-Use-the-new-feedback-call-to-send-the-feedback-to-Slack--edit-summary--SMI]-Use-the-new-feedback-call-to-send-the-feedback-to-Slack branch June 21, 2024 19:15
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 54.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamothe olamothe olamothe approved these changes

@toofff toofff toofff approved these changes

@dmgauthier dmgauthier Awaiting requested review from dmgauthier

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClaudineL @toofff @olamothe