Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UA-9179): add properties endpoints to client #839

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

aperron-coveo
Copy link
Contributor

@aperron-coveo aperron-coveo commented Jul 16, 2024

UA-9179

Added definitions for list, get, create, update and delete properties

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

Copy link
Member

@GermainBergeron GermainBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calls aren't available in Swagger, will they be soon? We should add them to our experimental client in the mean time instead of adding internal calls to this public repository

src/resources/AnalyticsAdmin/Properties/Properties.ts Outdated Show resolved Hide resolved
@aperron-coveo aperron-coveo force-pushed the feat/UA-9179-add-properties-endpoints-to-client branch from b45fb12 to e10230d Compare August 8, 2024 13:38
@aperron-coveo
Copy link
Contributor Author

The calls aren't available in Swagger, will they be soon? We should add them to our experimental client in the mean time instead of adding internal calls to this public repository

:sosolate: Its already in the experimental client, I'm just getting ready for when its public in swagger :p

@aperron-coveo
Copy link
Contributor Author

@GermainBergeron The calls are available in prod

@GermainBergeron
Copy link
Member

@aperron-coveo Are they supposed to be here? I can't find them 🤔

@aperron-coveo
Copy link
Contributor Author

@aperron-coveo Are they supposed to be here? I can't find them 🤔

I'm currently adding it to the proxy config https://github.com/coveo-platform/proxy/pull/1429, but for now its available here

@aperron-coveo aperron-coveo added this pull request to the merge queue Aug 22, 2024
Merged via the queue into master with commit b744a5b Aug 22, 2024
6 checks passed
@aperron-coveo aperron-coveo deleted the feat/UA-9179-add-properties-endpoints-to-client branch August 22, 2024 18:30
Copy link

🎉 This issue has been resolved in version 55.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants