Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(source): added new attributes for the SourceStatus interface - CTCORE-10153 #844

Merged
merged 1 commit into from
Aug 5, 2024
Merged

feat(source): added new attributes for the SourceStatus interface - CTCORE-10153 #844

merged 1 commit into from
Aug 5, 2024

Conversation

toofff
Copy link
Member

@toofff toofff commented Aug 5, 2024 •
edited
Loading

The source service adds 2 new attributes (activityId & createdDate) to the sourceStatus attribute to be aware of current activity.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@toofff toofff requested a review from a team August 5, 2024 18:39
@toofff toofff requested a review from a team as a code owner August 5, 2024 18:39
@toofff toofff enabled auto-merge August 5, 2024 18:49
@toofff toofff added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit 59353a7 Aug 5, 2024
7 checks passed
@toofff toofff deleted the feature/CTCORE-10153-add-new-attributes-in-source-entity branch August 5, 2024 18:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

🎉 This issue has been resolved in version 55.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveilleux aveilleux aveilleux approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@aboissinot-coveo aboissinot-coveo Awaiting requested review from aboissinot-coveo

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@alexprudhomme alexprudhomme Awaiting requested review from alexprudhomme alexprudhomme is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toofff @GermainBergeron @aveilleux