Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(usageanalytics): add deleteSnowflakeReaderAccount call to read s… #848

Merged
merged 2 commits into from
Aug 19, 2024
Merged

feat(usageanalytics): add deleteSnowflakeReaderAccount call to read s… #848

merged 2 commits into from
Aug 19, 2024

Conversation

mpayne-coveo
Copy link
Contributor

@mpayne-coveo mpayne-coveo commented Aug 15, 2024 •
edited
Loading

…ervice

Adds a call to DELETE /readeraccount on the Snowflake resource in the usageanalytics read service.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@mpayne-coveo mpayne-coveo marked this pull request as ready for review August 15, 2024 18:30
@mpayne-coveo mpayne-coveo requested a review from a team August 15, 2024 18:30
@mpayne-coveo mpayne-coveo requested a review from a team as a code owner August 15, 2024 18:30
@mpayne-coveo
Copy link
Contributor Author

Would anyone have a moment to take a look and help me merge in this PR? ^

@mpayne-coveo mpayne-coveo added this pull request to the merge queue Aug 19, 2024
Merged via the queue into master with commit bd581dc Aug 19, 2024
5 checks passed
@mpayne-coveo mpayne-coveo deleted the feat/UA-9144_add_delete_reader_account branch August 19, 2024 18:10
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 55.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboissinot-coveo aboissinot-coveo aboissinot-coveo approved these changes

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@toofff toofff Awaiting requested review from toofff

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault was automatically assigned from coveo/dx

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar was automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpayne-coveo @alexprudhomme @aboissinot-coveo