Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UA-9417): make daysToExpiry param optional + add response model #870

Merged
merged 3 commits into from
Oct 4, 2024
Merged

fix(UA-9417): make daysToExpiry param optional + add response model #870

merged 3 commits into from
Oct 4, 2024

Conversation

aperron-coveo
Copy link
Contributor

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@aperron-coveo aperron-coveo requested a review from a team as a code owner October 1, 2024 21:46
@aperron-coveo aperron-coveo requested a review from gdostie October 4, 2024 15:32
@gdostie gdostie added this pull request to the merge queue Oct 4, 2024
Merged via the queue into master with commit 72f75d2 Oct 4, 2024
5 checks passed
@gdostie gdostie deleted the fix/UA-9417-fix-signature-of-reactivate-user branch October 4, 2024 20:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

🎉 This PR is included in version 55.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphilippen rphilippen rphilippen approved these changes

@gdostie gdostie gdostie approved these changes

@mpayne-coveo mpayne-coveo Awaiting requested review from mpayne-coveo

@toofff toofff Awaiting requested review from toofff

@AdamMartineau-Coveo AdamMartineau-Coveo Awaiting requested review from AdamMartineau-Coveo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aperron-coveo @gdostie @rphilippen