Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-key): fix baseurl #890

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix(api-key): fix baseurl #890

merged 1 commit into from
Dec 2, 2024

Conversation

FelixBlaisThon
Copy link
Contributor

Coming from this PR. The first implementation did not correctly set the baseURL. This pr fixes it (by adding /rest/organizations/:orgId.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@FelixBlaisThon FelixBlaisThon requested review from a team as code owners December 2, 2024 20:35
@FelixBlaisThon FelixBlaisThon force-pushed the ADUI-10325-prevent-unsuccesful-api-key-creation-attempt branch from b463e52 to 524dda4 Compare December 2, 2024 20:35
@FelixBlaisThon FelixBlaisThon added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@FelixBlaisThon FelixBlaisThon added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@FelixBlaisThon FelixBlaisThon force-pushed the ADUI-10325-prevent-unsuccesful-api-key-creation-attempt branch from 524dda4 to 89742d6 Compare December 2, 2024 20:44
@FelixBlaisThon FelixBlaisThon added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@FelixBlaisThon FelixBlaisThon changed the title Ad UI 10325 prevent unsuccesful api key creation attempt fix(api-key): fix baseurl Dec 2, 2024
@FelixBlaisThon FelixBlaisThon added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit b6e73c9 Dec 2, 2024
6 checks passed
@FelixBlaisThon FelixBlaisThon deleted the ADUI-10325-prevent-unsuccesful-api-key-creation-attempt branch December 2, 2024 20:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 57.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdostie gdostie gdostie approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@GermainBergeron GermainBergeron Awaiting requested review from GermainBergeron GermainBergeron is a code owner automatically assigned from coveo/frontend-foundation

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/dx

@alexprudhomme alexprudhomme Awaiting requested review from alexprudhomme alexprudhomme is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelixBlaisThon @louis-bompart @gdostie