feat(statement-groups): add conditionDetailed property #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboissinot-coveo
requested review from
GermainBergeron,
FelixBlaisThon,
y-lakhdar,
louis-bompart and
fbeaudoincoveo
src/resources/Pipelines/StatementGroups/StatementGroupsInterfaces.ts
Outdated
Show resolved
Hide resolved
GermainBergeron
approved these changes
Dec 10, 2024
FelixBlaisThon
approved these changes
Dec 12, 2024
aboissinot-coveo
deleted the
SEARCHAPI-11324/statement-groups-condition
branch
|
🎉 This PR is included in version 57.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
paulgerold
pushed a commit
that referenced
this pull request
Dec 16, 2024
* feat(statement-groups): add conditionDetailed property * feat(statement-groups): adjust type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SEARCHAPI-11324
Add new
conditionDetailedproperty in theStatementGroupmodel.It was added in the backend as you can see in Swagger.
Note: it is currently typed as
anyas the other places where the "detailed" condition object is returned. The API doesn't provide a definitive type yet but it is currently being worked on. Once the API defines the schema, I'll updateplatform-clientto add the proper interfaces.Acceptance Criteria