Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modeldetails): renamed the property to the expected value #895

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(modeldetails): renamed the property to the expected value #895

merged 1 commit into from
Dec 13, 2024

Conversation

lprovost-coveo
Copy link
Contributor

@lprovost-coveo lprovost-coveo commented Dec 12, 2024 •
edited
Loading

Property was wrongly baptised, expected property name is
image

Technically it's not a breaking change since the property mapped to nothing before, and so changing the name doesn't break the change since nothing points to nothing

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@lprovost-coveo lprovost-coveo requested review from a team as code owners December 12, 2024 21:20
@lprovost-coveo lprovost-coveo added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit fecf9a9 Dec 13, 2024
6 checks passed
@lprovost-coveo lprovost-coveo deleted the fix/MLX-1749-fix-property-name branch December 13, 2024 19:33
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 57.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

paulgerold pushed a commit that referenced this pull request Dec 16, 2024
@lprovost-coveo @paulgerold
fix(modeldetails): renamed the property to the expected value (#895)
d6f9f08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgerold paulgerold paulgerold approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@FelixBlaisThon FelixBlaisThon Awaiting requested review from FelixBlaisThon FelixBlaisThon is a code owner automatically assigned from coveo/frontend-foundation

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

@JTangCoveo JTangCoveo Awaiting requested review from JTangCoveo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lprovost-coveo @GermainBergeron @paulgerold