Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call getUser instead of getSession in vulnerable cases #54

Closed
cowboycodr opened this issue Apr 5, 2024 · 2 comments
Closed

Call getUser instead of getSession in vulnerable cases #54

cowboycodr opened this issue Apr 5, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@cowboycodr
Copy link
Owner

supabase.auth.getSession is a potential security risk in some instances because it gets the user's identity from storage that the client can manipulate. However, it is much faster as it does not make a fetch to the db.

We need to balance the use of getSession and getUser out so that the page is snappy, but needs to be very secure.
@cowboycodr cowboycodr added bug Something isn't working enhancement New feature or request labels Apr 5, 2024
@cowboycodr
Copy link
Owner Author

idk -- supabase seems to be at conflict with itself on this one.

supabase/auth-helpers#755

@cowboycodr
Copy link
Owner Author

So for the mean time, because of the previous comment, I'm closing this.

Repository owner locked and limited conversation to collaborators Apr 12, 2024
@cowboycodr cowboycodr closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
Repository owner unlocked this conversation Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowboycodr