fix: Make sure the initializing promise is reset on logout

packages/cozy-flags/src/flag.js

@@ -140,11 +140,19 @@ class FlagClientPlugin {
     this.client.on('login', this.handleLogin)
     this.client.on('logout', this.handleLogout)
 
+    this.setupInitializing()
+
+    if (client.isLogged) this.handleLogin()
+  }
+
+  /**
+   * Sets up a promise that can be awaited to wait for flag complete
+   * initialization
+   */
+  setupInitializing() {
     this.initializing = new Promise(resolve => {
       this.resolveInitializing = resolve
     })
-
-    if (client.isLogged) this.handleLogin()
   }
 
   async handleLogin() {
@@ -154,6 +162,7 @@ class FlagClientPlugin {
 
   async handleLogout() {
     flag.reset()
+    this.setupInitializing()
   }
 }
 

packages/cozy-flags/src/tests.js

@@ -1,4 +1,5 @@
 import CozyClient from 'cozy-client'
+import util from 'util'
 
 export default function testFlagAPI(flag) {
   afterEach(() => {
@@ -112,6 +113,23 @@ export default function testFlagAPI(flag) {
         expect(flag('number_of_foos')).toBe(10)
         expect(flag('bar_config')).toEqual({ qux: 'quux' })
       })
+
+      it('should reset the initializing promise on logout', async () => {
+        const { client } = setup()
+        client.isLogged = true
+        client.registerPlugin(flag.plugin)
+
+        const initializing1 = client.plugins.flags.initializing
+        const state = util.inspect(initializing1)
+        expect(state).toContain('pending')
+        await client.plugins.flags.initializing
+        const state2 = util.inspect(initializing1)
+        expect(state2).not.toContain('pending')
+        await client.logout()
+        const initializing2 = client.plugins.flags.initializing
+        expect(initializing2).not.toBe(initializing1)
+        expect(util.inspect(initializing2)).toContain('pending')
+      })
     })
 
     if (typeof document !== 'undefined') {