Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Load flags from legacy DOM #968

Merged
merged 2 commits into from
Feb 24, 2020
Merged

fix: Load flags from legacy DOM #968

merged 2 commits into from
Feb 24, 2020

Conversation

y-lohse
Copy link
Contributor

@y-lohse y-lohse commented Feb 24, 2020

There was a small typo causing a crash when we tried to load flags from the data-cozy-flags DOM node.

@y-lohse y-lohse requested a review from ptbrowne February 24, 2020 08:27
@y-lohse y-lohse requested a review from drazik as a code owner February 24, 2020 08:27
@y-lohse y-lohse self-assigned this Feb 24, 2020
ptbrowne
ptbrowne approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ! fit -> it ;)

@y-lohse @ptbrowne
tests: Un-focus test
1a0fe21 
Co-Authored-By: Patrick Browne <[email protected]>
@y-lohse y-lohse merged commit 6f54cc7 into master Feb 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-legacy-flags branch February 24, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne ptbrowne approved these changes

@drazik drazik Awaiting requested review from drazik

Assignees

@y-lohse y-lohse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-lohse @ptbrowne