Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to blackfriday v2.0.0 API #28

Closed
tamird opened this issue Aug 15, 2017 · 5 comments
Closed

update to blackfriday v2.0.0 API #28

tamird opened this issue Aug 15, 2017 · 5 comments

Comments

@tamird
Copy link

tamird commented Aug 15, 2017

https://github.com/russross/blackfriday/releases/tag/v2.0.0
@zevdg
Copy link
Contributor

zevdg commented Aug 24, 2017 •
edited
Loading

As a temporary measure, the import could at least be changed to gopkg.in/russross/blackfriday.v1

That or if this project were updated to use dep, a version constraint could be put on blackfriday

[[constraint]]
  name = "github.com/russross/blackfriday"
  version = "1.4"

FYI, this causes issues for anyone who tries to import this package using dep.

@zevdg zevdg mentioned this issue Aug 24, 2017
Closed
@cpuguy83
Copy link
Owner

@zevdg It's already vendored.

@tamird
Copy link
Author

tamird commented Aug 24, 2017

Some tools flatten dependencies' vendor directories, fwiw.

@cpuguy83
Copy link
Owner

Happy to use dep if someone wants to convert it over.
Also if gopkg is the canonical import path, happy to use that as well.

This was referenced Aug 24, 2017
Closed
Merged
@estesp estesp mentioned this issue Jan 29, 2018
Merged
@cpuguy83
Copy link
Owner

Being implemented in #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zevdg @cpuguy83 @tamird