Merge pull request #16313 from craftcms/bugfix/16310-tags-replace-ele…

…ment-action tags shouldn't have replace action
craftcms · Dec 11, 2024 · 326688d · 326688d
2 parents 665c919 + a3bfda4
commit 326688d
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Fixed a bug where Tags fields had “Replace” actions. ([#16310](https://github.com/craftcms/cms/issues/16310))
 - Fixed a styling issue in Safari. ([#16298](https://github.com/craftcms/cms/issues/16298))
 
 ## 5.5.6 - 2024-12-10

diff --git a/src/web/assets/cp/dist/cp.js b/src/web/assets/cp/dist/cp.js
diff --git a/src/web/assets/cp/dist/cp.js.map b/src/web/assets/cp/dist/cp.js.map
diff --git a/src/web/assets/cp/src/js/BaseElementSelectInput.js b/src/web/assets/cp/src/js/BaseElementSelectInput.js
@@ -465,14 +465,16 @@ Craft.BaseElementSelectInput = Garnish.Base.extend(
       }
 
       if (this.settings.allowRemove) {
-        actions.push({
-          icon: 'arrows-rotate',
-          label: Craft.t('app', 'Replace'),
-          callback: () => {
-            this._$replaceElement = $element;
-            this.showModal();
-          },
-        });
+        if (this.settings.elementType) {
+          actions.push({
+            icon: 'arrows-rotate',
+            label: Craft.t('app', 'Replace'),
+            callback: () => {
+              this._$replaceElement = $element;
+              this.showModal();
+            },
+          });
+        }
 
         actions.push({
           icon: 'remove',