Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[craft make plugin] rejects composer package name that has numbers in it #4

Closed
wsydney76 opened this issue Dec 15, 2022 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@wsydney76
Copy link

Description

We use numbers in the composer package name, which should be fine: https://getcomposer.org/doc/04-schema.md#name, but is rejected as Invalid input.

Looks like 'pattern' => '/^[a-z][a-z\\-]*\\/[a-z][a-z\\-]*$/', is used, which is too strict.

Steps to reproduce

  1. run craft make plugin
  2. enter wsydney76/testplugin when prompted for Composer package name

Additional info

  • Craft version: 4.3.5
  • PHP version:
  • Database driver & version:
  • Plugins & versions:

/ Klara

@wsydney76 wsydney76 added the bug Something isn't working label Dec 15, 2022
@khalwat
Copy link

khalwat commented Dec 15, 2022

Yep, I ran into this, too:

Composer package name: [nystudio/mistletoe] nystudio107/craft-mistletoe
Invalid input.

nystudio107 as a company is banned. I feel attacked 😄

@brandonkelly
Copy link
Member

Thanks for reporting! 1.0.3 is out now with Composer’s recommended package name pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants