Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glowstone not recognized as an ore? should it be? #5

Open
crashdemons opened this issue Apr 19, 2020 · 3 comments
Open

Glowstone not recognized as an ore? should it be? #5

crashdemons opened this issue Apr 19, 2020 · 3 comments
Labels
question Further information is requested
Milestone

Comments

@crashdemons
Copy link
Owner

No description provided.

@crashdemons crashdemons added the question Further information is requested label Apr 19, 2020
@crashdemons
Copy link
Owner Author

what about clay for that matter - or is it because you use a different tool?

@crashdemons crashdemons modified the milestones: v2.0, far-future Apr 19, 2020
@EvModder
Copy link

EvModder commented Feb 8, 2021

Personal opinion: If the material name ends with "_ore", it is an ore, otherwise it is just a material that requires a special tool.

Related: I believe Bukkit API Material enum provides a dropsSelf() (or something similar), which can be used to identify blocks such as glowstone, clay, gravel, ender_chest etc. that drop "fragments" when not using Silk Touch

@crashdemons
Copy link
Owner Author

That was kind of my initial idea with "_ore" also, but I also decided to include ancient debris since it had the same smelting requirement as other metallic ore, so that's where we're at now and maybe it doesn't need fixing...

Also, Interesting API method - that may be useful for MiningTrophies, or at least help generate candidates (although I don't know if I want to have a huge list of trophies - it's nice to have smaller goals compared to PH's)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants