Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the variable scoping styling and updated rake file for epp validation #2

Merged
merged 9 commits into from
May 6, 2016
Merged

fixed the variable scoping styling and updated rake file for epp validation #2

merged 9 commits into from
May 6, 2016

Conversation

tuxfight3r
Copy link

  • Fixed the variable scoping styling in *.pp files
  • Updated Rakefile for epp validation
  • Updated readme for typo
  • Removed #rsyslog::client::templates option from example data/common.yaml as templates option not declared in client.pp

@crayfishx crayfishx self-assigned this May 6, 2016
@crayfishx crayfishx added this to the 0.1.1 milestone May 6, 2016
@crayfishx crayfishx added enhancement New feature or request accepted labels May 6, 2016
@crayfishx
Copy link
Contributor

Thanks for this contribution @tuxfight3r ... I'll get it merged and released asap.... In future if you could submit separate pull requests for separate pieces of work it makes reviewing it easier and changes quicker (eg: variable scoping in one, contributors document in another, epp testing in another...etc)

Thanks

@crayfishx crayfishx merged commit 8745458 into voxpupuli:master May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crayfishx crayfishx

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tuxfight3r @crayfishx