From aa294abfc108d933668a5ac3902756fb207d9d86 Mon Sep 17 00:00:00 2001 From: Yao Xiao Date: Fri, 24 Jul 2020 10:22:22 -0700 Subject: [PATCH] Use istio-parameter in manifests (#380) --- pkg/kfapp/aws/aws.go | 4 ---- pkg/kfconfig/types.go | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/pkg/kfapp/aws/aws.go b/pkg/kfapp/aws/aws.go index 477e322a..d2b64fd4 100644 --- a/pkg/kfapp/aws/aws.go +++ b/pkg/kfapp/aws/aws.go @@ -467,10 +467,6 @@ func (aws *Aws) Generate(resources kftypes.ResourceEnum) error { } } else { if pluginSpec.Auth.Cognito != nil { - if err := aws.kfDef.SetApplicationParameter("istio", "clusterRbacConfig", "ON"); err != nil { - return errors.WithStack(err) - } - if err := aws.kfDef.SetApplicationParameter("istio-ingress", "CognitoUserPoolArn", pluginSpec.Auth.Cognito.CognitoUserPoolArn); err != nil { return errors.WithStack(err) } diff --git a/pkg/kfconfig/types.go b/pkg/kfconfig/types.go index 442c2b62..5d974aa7 100644 --- a/pkg/kfconfig/types.go +++ b/pkg/kfconfig/types.go @@ -844,7 +844,7 @@ func (c *KfConfig) SetApplicationParameter(appName string, paramName string, val "spartakus": "spartakus", // AWS Specific "aws-alb-ingress-controller": KfAppsStackName, - "istio-ingress": KfAppsStackName, + "istio-ingress": "istio-ingress", } appNameDir, ok := appToStack[appName]