Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Buildscripts for Makefile #68

Open
Breee opened this issue Jun 23, 2024 · 0 comments
Open

Centralize Buildscripts for Makefile #68

Breee opened this issue Jun 23, 2024 · 0 comments

Comments

@Breee
Copy link
Contributor

Breee commented Jun 23, 2024

Problem Statement:

I find myself coming back often to this repository whenever my CI/CD flow breaks, to see if the Makefile has changed

Generally an upjet generated provider only needs these variables:

export PROJECT_NAME ?= provider-keycloak
export PROJECT_REPO ?= github.com/crossplane-contrib/$(PROJECT_NAME)
export TERRAFORM_PROVIDER_SOURCE ?= mrparkers/keycloak
export TERRAFORM_PROVIDER_REPO ?= https://github.com/mrparkers/terraform-provider-keycloak
export TERRAFORM_PROVIDER_VERSION ?= 4.4.0
export TERRAFORM_PROVIDER_DOWNLOAD_NAME ?= terraform-provider-keycloak
export TERRAFORM_PROVIDER_DOWNLOAD_URL_PREFIX ?= ${TERRAFORM_PROVIDER_REPO}/releases/download/v$(TERRAFORM_PROVIDER_VERSION)
export TERRAFORM_NATIVE_PROVIDER_BINARY ?= terraform-provider-keycloak_v4.4.0
export TERRAFORM_DOCS_PATH ?= docs/resources

if i push to a custom registry one might as well need:

REGISTRY_ORGS
XPKG_REG_ORGS

the rest really could be just imported imo

Proposed solution:

  • Remove everything that should not be customized from the Makefile and move it into the build submodule or be packaged in some other way (Maybe as OCI) and could also be versioned maybe.
  • As a side effect, this would make it easier to renovate the dependencies, such as
GOLANGCILINT_VERSION
KIND_VERSION
UP_VERSION
UPTEST_VERSION

centralized and also help with pinning TERRAFORM_VERSION to 1.5.7 to enforce that version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant