Set the RawPlan for a new terraform.InstanceState returned from an observation #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
…eStateToJSONMap Signed-off-by: Alper Rifat Ulucinar <[email protected]>
…servation Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
fix-customize-diff
branch
from
16015ce
to
f0de67a
Compare
1 task
mbbush
added a commit
to mbbush/upjet
that referenced
this pull request
Jan 24, 2024
…-diff" This reverts commit 1d547af, reversing changes made to 0bc8185. Signed-off-by: Matt Bush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR sets the
RawPlanfor a newterraform.InstanceStatereturned from an observation. We need this to get the registeredschema.Resource.CustomizeDifffunctions working in the context of crossplane-contrib/provider-upjet-aws#1037, which bumps the underlying Terraform AWS provider version tov5.31.0.It also adds an import alias for the
github.com/hashicorp/terraform-plugin-sdk/v2/diagpackage as thediagpackage name collides with some existing variable names.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested via uptest in https://github.com/upbound/provider-aws/actions/runs/7300282700