Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsequent pushes to existing PR/branch lead to stuck PR actions #34

Closed
Yserz opened this issue Sep 24, 2020 · 10 comments
Closed

Subsequent pushes to existing PR/branch lead to stuck PR actions #34

Yserz opened this issue Sep 24, 2020 · 10 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Yserz
Copy link

Yserz commented Sep 24, 2020

Describe the bug
When a fresh PR/branch is created by the action it seems to use the provided GITHUB_TOKEN so the owner of the token is displayed as creator of the PR. When an update to this PR is pushed from the action it seems it uses the default github.token and github-actions is the creator of the push. This seems to not allow to run other actions on the updated PR (I suspect to prevent infinite loops). Here's an example: wireapp/wire-webapp#9696.

To Reproduce
Steps to reproduce the behavior:

  1. Change the translations files in order to create a new PR/branch with the action (creator will be otto-the-bot and other actions are running through)
  2. Add another change and trigger the action (push is created by github-actions)
  3. Other actions running on this PR are stuck and never complete.

Expected behavior
Subsequent pushes are created from otto-the-bot instead of github-actions

@Yserz Yserz added the bug Something isn't working label Sep 24, 2020
@Yserz Yserz changed the title Subsequent pushes to existing PR/branch are not using provided GITHUB_TOKEN Subsequent pushes to existing PR/branch lead to stuck PR actions Sep 30, 2020
@andrii-bodnar andrii-bodnar added the help wanted Extra attention is needed label Oct 1, 2020
@Yserz
Copy link
Author

Yserz commented Sep 15, 2021

https://docs.github.com/en/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token

@VBeytok VBeytok added the good first issue Good for newcomers label Sep 17, 2021
@ottosuess
Copy link

ottosuess commented Apr 19, 2022

we're also having this problem.
in our case it's really annoying because we're running the action to create the PR with a cron job.
every time the job runs and there is already a PR all the checks get invalidated and don't run again. (because the action also force pushes when translation have not changed.)

would be really nice if this gets fixed soon 🙏

@ottosuess
Copy link

how is this issue related to parallel runs?

has this been fixed?

@andrii-bodnar
Copy link
Member

@ottosuess my apologies, closed it by mistake

@andrii-bodnar andrii-bodnar reopened this Oct 18, 2022
@andrii-bodnar andrii-bodnar removed the good first issue Good for newcomers label Oct 18, 2022
@andrii-bodnar
Copy link
Member

@ottosuess do you have some ideas on how this issue might be fixed? Are there any alternative solutions or features you've considered?

@zomars
Copy link

zomars commented Jan 12, 2023

We're having the same issue. We used auto update with kodiak. When that happens, checks start running again. But minutes later the crowdin action force pushes and the checks gets cancelled.

@zomars
Copy link

zomars commented Jan 12, 2023

Even setting a workflow_run as trigger doesn't trigger the checks as described in the docs.

@DimaYashchyshyn
Copy link

Thanks @zomars we'll check this.

@zomars
Copy link

zomars commented Jan 12, 2023

Here's an example calcom/cal.com#6444

EDIT:

You can see that required-checks is expected but never run. When the commit comes from kodiak it starts running.

image

But after a minute it gets overridden by crowdin and the checks are cancelled.

@wojsmol
Copy link

wojsmol commented Oct 21, 2023

Hi all
Please see this comment by me on #142 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants