Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Speed #3

Open
jprichardson opened this issue Jun 11, 2014 · 7 comments
Open

Improve Speed #3

jprichardson opened this issue Jun 11, 2014 · 7 comments

Comments

@jprichardson
Copy link
Member

This algorithm is slower than it needs to be. Revert internal buffer usage to improve speed. Consider analysis from this article: http://blog.ircmaxell.com/2014/03/why-i-dont-recommend-scrypt.html

@jprichardson
Copy link
Member Author

Benchmark against: https://github.com/tonyg/js-scrypt

@jprichardson
Copy link
Member Author

Did a quick informal benchmark of scryptsy against js-scrypt using params of {N: 64, r: 4, p: 4} and dkLen or 64. js-scrypt is slightly faster (wall-clock), but its memory footprint is much much greater. There's a lot of room for optimizations for scryptsy.

@dcousens
Copy link
Contributor

This is way faster (in node) now thanks to it using the pbkdf2 module, which can use the native sha256 in node 0.12 but falls back to a native JS module in node 0.10.

@thinkloop
Copy link

Thanks for the lib, works decently in chrome, but it is unusable in FF 44.0.2, locks up the browser forcing a hard close

@dcousens
Copy link
Contributor

dcousens commented Mar 2, 2016

@thinkloop as in, forever?
That sounds like something to report to Mozilla...

@fanatid
Copy link
Member

fanatid commented Mar 2, 2016

it is very strange, firefox 44 has almost same speed as chrome 49 for pbkdf2

@thinkloop
Copy link

scrypt-async works well in all browsers, has zero locking for any chosen paramters, and I verified results against the node.js reference lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants