Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use x25519-dalek instead of -ng version? #54

Closed
japaric opened this issue Nov 27, 2023 · 1 comment · Fixed by #57
Closed

use x25519-dalek instead of -ng version? #54

japaric opened this issue Nov 27, 2023 · 1 comment · Fixed by #57

Comments

@japaric
Copy link
Contributor

japaric commented Nov 27, 2023

the latest version of x25519-dalek-ng (v1.1.1) does not compile to a no-std target like thumbv7em-none-eabihf because it doesn't disable the default features of its rand dependency and that brings in a dependency on libstd due to its opt-out "std" feature. I can certainly send a fix for that but given that the repository / crate has not been updated / released since early 2021, it's possible that the fix never makes it into a release.

would it be possible to use x25519-dalek instead of the -ng one? the former has proper no-std support and seems to be more actively maintained.

@franziskuskiefer
Copy link
Member

I'd be fine switching to the -ng create.

On that crypto provider in general: This crypto provider is really here for convenience but I don't use it too much myself. I know these crates are popular, but I generally recommend using other crypto libraries that don't lead to a dependency hell like this. The everest provider is not maintained anymore and I'll remove it. But I'll add a libcrux one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants