Add a (slightly) better CLI #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samis Thanks! Could you squash the commits? |
mverzilli
requested changes
Feb 19, 2017
| output_file = "" | ||
| OptionParser.parse! do |parser| | ||
| parser.banner = "Usage: crystal_lib [arguments]" | ||
| parser.on("-o FILE", "--output=FILE", "The file to output the generated code to.") { |filename| output_file = filename } |
There was a problem hiding this comment.
Clarify the default if it's not specified (for example: "defaults to output.cr"). Actually, it'd be nice if the default took the same name as the input file, except with the cr extension.
| OptionParser.parse! do |parser| | ||
| parser.banner = "Usage: crystal_lib [arguments]" | ||
| parser.on("-o FILE", "--output=FILE", "The file to output the generated code to.") { |filename| output_file = filename } | ||
| parser.on("-h", "--help", "Show this help") { puts parser; Process.exit(0) } |
There was a problem hiding this comment.
We should provide an option to print to the console, as it works currently.
| output_file = "output.cr" | ||
| end | ||
|
|
||
| node = Crystal::Parser.parse(ARGF.gets_to_end) |
There was a problem hiding this comment.
This breaks when the user doesn't provide an input file. It should show usage instead.
| require "option_parser" | ||
| output_file = "" | ||
| OptionParser.parse! do |parser| | ||
| parser.banner = "Usage: crystal_lib [arguments]" |
There was a problem hiding this comment.
Some sort of clarification that the last argument should be the input file is missing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minimal, but still working CLI allowing to specify both the input and the output files on the command line. While it's very basic and does not support reading from stdin or outputting to stdout, it does work.