Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some "insecure" options are hardcoded to true #2216

Closed
wkloucek opened this issue Oct 28, 2021 · 1 comment
Closed

Some "insecure" options are hardcoded to true #2216

wkloucek opened this issue Oct 28, 2021 · 1 comment
Labels
bug Something isn't working junior-job Easy issues

Comments

@wkloucek
Copy link
Contributor

wkloucek commented Oct 28, 2021

Describe the bug

Some REVA "insecure" configurations default to true.

Expected behavior

"insecure" options (most of the time it's SSL cert validation check skip) must be configurable and default to false.

Actual behavior

some "insecure" options default to true, eg.

GRPC connections use also the insecure option (https://grpc.io/docs/guides/auth/#go)

@wkloucek
Copy link
Contributor Author

is no longer be the case on "edge" branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working junior-job Easy issues
Projects
None yet
Development

No branches or pull requests

2 participants