Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: need to fill in the MarkdownStyleSheet decorations #66

Open
csells opened this issue Oct 27, 2024 · 0 comments
Open

bug: need to fill in the MarkdownStyleSheet decorations #66

csells opened this issue Oct 27, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@csells
Copy link
Owner

csells commented Oct 27, 2024

The LlmMessageStyle has embedded a MarkdownStyleSheet. It has values for the important things except these four decorations:

  • blockquoteDecoration
  • codeblockDecoration
  • horizontalRuleDecoration
  • tableCellsDecoration

These should be set in the lightStyles method and inverted in the darkStyles method like so:

        blockquoteDecoration:
            sh.invertDecoration(markdownStyle.blockquoteDecoration),
        codeblockDecoration:
            sh.invertDecoration(markdownStyle.codeblockDecoration),
        horizontalRuleDecoration:
            sh.invertDecoration(markdownStyle.horizontalRuleDecoration),
        tableCellsDecoration:
            sh.invertDecoration(markdownStyle.tableCellsDecoration),

Otherwise, when these decorations are used, they'll be whatever default they are and not a) match the styles of the LlmChatView and b) won't switch to dark.

@csells csells added the bug Something isn't working label Oct 27, 2024
@csells csells added this to the stable milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant