Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

VisualStudioVersion not set correctly for portable projects #83

Closed
ctaggart opened this issue Jun 30, 2015 · 2 comments
Closed

VisualStudioVersion not set correctly for portable projects #83

ctaggart opened this issue Jun 30, 2015 · 2 comments

Comments

@ctaggart
Copy link
Owner

I compiled and included the latest open source MSBuild so that VisualStudioVersion would be set correctly when loading projects . Unfortunately, it appears that this solution may not be working for portable projects.

original problem: #50
original solution: http://blog.ctaggart.com/2015/05/sourcelinkmsbuild-uploaded-to-nuget.html

On AppVeyor it evaluated to 10.0:
fsprojects/FSharp.Data#852
image

On my computer it evaluated to 11.0:
image

In both cases, it should have been set to 12.0 for Visual Studio 2013.

The original work-a-round was to hardcode the setting to load:

let proj = VsProj.Load file ["Configuration","Release"; "VisualStudioVersion","12.0"]

Instead of:

let proj = VsProj.LoadRelease file

Another test work trying is commenting out Common.props.

<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
@ctaggart
Copy link
Owner Author

I filed this as dotnet/msbuild#122.

@ctaggart
Copy link
Owner Author

I'll upgrade MSBuild versions as they come out. Not much I can do about this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant