Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NextJS 11 Middleware support #14

Open
ctrlaltdylan opened this issue Oct 24, 2021 · 2 comments
Open

Add NextJS 11 Middleware support #14

ctrlaltdylan opened this issue Oct 24, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@ctrlaltdylan
Copy link
Owner

NextJS will soon be introducing a new way of including global or grouped middlewares.

We'll just need to make sure shopify-nextjs-toolbox plays nicely with this change.
@ctrlaltdylan ctrlaltdylan added the enhancement New feature or request label Oct 24, 2021
@jonathangiardino
Copy link

jonathangiardino commented Oct 26, 2021 •
edited
Loading

Looking forward to see how this new next middleware will play with shopify-nextjs-toolbox.

Do you think we could be able to do the whole handshake in a middleware?

@ahmed-adly-khalil
Copy link

subscribed, I think an upgrade to next 12.0.2 (latest as of now) would be great as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ctrlaltdylan @ahmed-adly-khalil @jonathangiardino