Skip to content
This repository has been archived by the owner on May 28, 2019. It is now read-only.

Gherkin::Formatter::AnsiEscapes methods should be namespaced to avoid clashes with other methods #157

Closed
Empact opened this issue Feb 1, 2012 · 2 comments
Closed

Gherkin::Formatter::AnsiEscapes methods should be namespaced to avoid clashes with other methods #157

Empact opened this issue Feb 1, 2012 · 2 comments

Comments

@Empact
Copy link
Contributor

Empact commented Feb 1, 2012

There are a number of AnsiEscapes methods which are quite general and in particular I ran into a bug whereby using cucumber with RR resulted in an error because both AnsiEscapes and RR implement a #reset method.

Here's my pull request to rename those methods in RR: btakita/rr#77
@aslakhellesoy
Copy link
Contributor

I don't think this will be a problem anymore when we stop mixing in the AnsiEscapes module in Ccuumber's World - when cucumber/common#219 is solved.

Would you agree with that?

@Empact
Copy link
Contributor Author

Empact commented Feb 7, 2012

Yeah, I agree these are the same problem. Let's carry on over there.

@Empact Empact closed this as completed Feb 7, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslakhellesoy @Empact