Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unsupported rubies #385

Merged
3 commits merged into from
Apr 29, 2016
Merged

Drop unsupported rubies #385

3 commits merged into from
Apr 29, 2016

Conversation

maxmeyer
Copy link
Member

Summary

This PR drops supported for unsupported rubies from 1.0.0 on.

@maxmeyer maxmeyer force-pushed the feature/drop-unsupported-rubies branch from ba7e538 to 973859b Compare April 28, 2016 20:14
@ghost ghost merged commit 9178f4d into master Apr 29, 2016
@ghost ghost mentioned this pull request Apr 29, 2016
@mattwynne
Copy link
Member

Did you run this past @myronmarston? Those of us maintaining test frameworks like to be able to support our users on older Rubies. I think this will mean RSpec and Cucumber won't be able to use Aruba 1.0.

@myronmarston
Copy link

I think this will mean RSpec and Cucumber won't be able to use Aruba 1.0.

That's true if we wanted to use Aruba 1.0 in RSpec's test suite for RSpec 3.x. But in RSpec 4 we'll be dropping old ruby versions, too (probably 1.8.7 and 1.9.2 like you've done here) so we can just wait to upgrade to Aruba 1.0 until that point. The old version of aruba we are on is meeting our needs just fine :).

@mattwynne
Copy link
Member

Sweet!

Ref #363

@maxmeyer
Copy link
Member Author

I dropped support for rubies < 1.9.3. Cucumber 2 requires > 1.9.3, correct?

I had in mind that Myron wants to drop old ruby support in the upcoming major release and that he's "fine" with version dropping in major versions in aruba.

I think, the 1.0.0 release will be a major clean up + repair release. I really want to get rid of the deprecated code which is still part of aruba for months, sometimes even years.

Am 29. April 2016 20:16:36 MESZ, schrieb Matt Wynne [email protected]:

Did you run this past @myronmarston? Those of us maintaining test
frameworks like to be able to support our users on older Rubies. I
think this will mean RSpec and Cucumber won't be able to use Aruba 1.0.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#385 (comment)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants