Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber-rails: Ruby 2.7 readiness issue #455

Closed
olleolleolle opened this issue Jan 8, 2020 · 5 comments
Closed

cucumber-rails: Ruby 2.7 readiness issue #455

olleolleolle opened this issue Jan 8, 2020 · 5 comments

Comments

@olleolleolle
Copy link
Contributor

Summary

We want to be compatible with current Ruby versions. 2.7 is not yet in the matrix. It could be.

Expected Behavior

  • Have 2.7 in CI matrix
  • No Ruby 2.7 warnings from the test suite
  • All tests pass (or, no tests fail due to 2.7)

Current Behavior

  • Does not have Ruby 2.7 in the test matrix

Possible Solution

  • Extend the matrix.

Context & Motivation

Rails is moving forwards with their warnings-removal work for 2.7. This is a Rails plugin. Would be nice to move in the same direction.

@luke-hill
Copy link
Contributor

I would advise that this is hard-blocked by the issues in cucumber / cucumber-core repos.

cucumber/cucumber-ruby-core#187
cucumber/common#843

@olleolleolle
Copy link
Contributor Author

@luke-hill Both of these issues are closed.

@DannyBen
Copy link

DannyBen commented May 5, 2020

Since the cucumber-ruby gem is in 4.0 Release Candidate state for over a year, may I suggest to consider at least releasing a cucumber-rails RC version, with the latest and greatest cucumber(RC) and cucumber-core?

This lag is beginning to have an impact on productivity, I guess not only for me.

I opened cucumber/cucumber-ruby#1417 hoping to at least get some sense of how much longer it will take.

@luke-hill
Copy link
Contributor

@DannyBen This issue is now hard blocked on #466 and I suggest once #466 is released we can probably close this as no longer relevant / fixed.

as for getting cucumber ruby 4 support in cucumber rails, This was done recently in the Open Source work. However it's anticipated some small issues might come crawling out.

@olleolleolle
Copy link
Contributor Author

@mvz You've gotten #466 merged - and I just checked, no warnings are showing in the Job

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants